[Security] [LoginLink] Add technical details #17872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Feb 7, 2023
OskarStark
reviewed
Feb 7, 2023
OskarStark
reviewed
Feb 7, 2023
OskarStark
reviewed
Feb 7, 2023
alexandre-daubois
force-pushed
the
login-link-details
branch
from
2344230 to
dfc63bb
Compare
|
That's all updated. Thanks for the review and the text code block tip! |
OskarStark
reviewed
Feb 8, 2023
OskarStark
approved these changes
Feb 8, 2023
alexandre-daubois
force-pushed
the
login-link-details
branch
from
dfc63bb to
9309628
Compare
carsonbot
changed the title
|
I didn't know about these double-hashing details. Thanks Alex for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17139
Although a bit technical, I think it's a good idea to give a bit of details to the reader on this kind of subject. If the reader needs more information and is more curious, the linked classes will be there to guide him through the good parts of the code 👍